Parse rc.local.d directory on boot #474
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 69.89% 69.89%
=======================================
Files 3 3
Lines 475 475
=======================================
Hits 332 332
Misses 143 143 ☔ View full report in Codecov by Sentry. |
ben-grande
force-pushed
the
rc-local-dir
branch
from
f0e93e6
to
efc0ab5
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023120304-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023111404-4.2&flavor=update
Failed tests7 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/85616#dependencies 6 fixed
Unstable tests
|
|
Maybe I am late because OpenQA has already run but should I only parse files with extensions like
|
Generally it's a good idea, maybe just |
|
On 23-12-01 05:56:57, Marek Marczykowski-Górecki wrote:
> Although it is a script, a extension might be useful to avoid parsing unwanted files...
Generally it's a good idea, maybe just `.sh`? I find it weird to have arbitrary script with `.conf` (I know bind-dirs is such a case already, but it's supposed to configure specific variable, not run arbitrary commands, even if technically it's possible). Alternatively, require files to be executable, but that may be not enough to prevent running `.bak`, `.rpmsave` etc files...
I don't know of a suitable extension but it should not be ".sh" as it
doesn't need to be a ShellScript, it can be any type of executable file.
It is already requiring the file to be executable though, so an
extension is just a safeguard.
What do you think of ".rc"? As in:
- /rw/config/rc.local.d: any executable
- bashrc: ShellScript, configuration, function and commands
- vimrc: VimScript, configuration, function and commands
Although normally it is for shellscripts, let's take the meaning of
"runcom" or "run commands":
https://unix.stackexchange.com/a/3469
…--
Benjamin Grande
|
Sounds okay. |
ben-grande
force-pushed
the
rc-local-dir
branch
from
efc0ab5
to
e40a621
Compare
Fixes QubesOS/qubes-issues#8690